(PDK-1100) Exclude known artifacts from build instead of cleaning #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjen
reviewed
Oct 3, 2018
| @@ -215,6 +213,8 @@ def ignored_files | |||
| ignored = ignored.add("\/#{File.basename(target_dir)}\/") | |||
| end | |||
|
|
|||
| DEFAULT_IGNORED.each { |r| ignored.add(r) } | |||
There was a problem hiding this comment.
This will add duplicate entries to the ignore list if there are common ignores between the pmt/pdk/git ignore files and the defaults.
There was a problem hiding this comment.
Duplicates shouldn't cause an issue (just as you can have duplicate entries in a .gitignore).
There was a problem hiding this comment.
True, we don't currently clear dupes from the ignore file either.
scotje
reviewed
Oct 3, 2018
| # @return nil | ||
| def cleanup_module | ||
| PDK::Util::Bundler.ensure_bundle! | ||
| PDK::Util::Bundler.ensure_binstubs!('rake') |
There was a problem hiding this comment.
Does this need to re-appear somewhere?
There was a problem hiding this comment.
Nope, the purpose of this change is to remove the need for the in-module bundler environment when building release tarballs
bmjen
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By handling it in this manner, we can remove the need to call the PDK shipped
spec_cleantask. This is the only dependency on the PDK runtime environment when callingPDK::Module::Build.invokefrom outside of PDK (as needs to be done in puppetlabs_spec_helper'sbuildrake task).