Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1187) Don't override bundler path on gem installs #592

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Nov 9, 2018

If PDK has been installed as a gem (for example, specified in a module's Gemfile), don't try to force a particular bundler path as this will usually conflict with the user specified path and break their workflow.

PS C:\Users\tsharpe\puppetlabs-windows> bundle exec pdk build
pdk (INFO): Building puppetlabs-windows version 5.0.0
pdk (INFO): Build of puppetlabs-windows has completed successfully. Built package can be found here: C:/Users/tsharpe/puppetlabs-windows/pkg/puppetlabs-windows-5.0.0.tar.gz
PS C:\Users\tsharpe\puppetlabs-windows> bundle exec puppet --version
6.0.4
PS C:\Users\tsharpe\puppetlabs-windows> cat .\.bundle\config
---
BUNDLE_PATH: ".bundle/gems"

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.985% when pulling 66137ad on rodjek:pdk-1187 into 5158bfd on puppetlabs:master.

@bmjen bmjen merged commit 674f2c7 into puppetlabs:master Nov 13, 2018
@rodjek rodjek deleted the pdk-1187 branch November 14, 2018 00:16
@bmjen bmjen added the bug label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants