New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1180) Cleanly handle a null pdk-version in metadata.json #599

Merged

bmjen merged 1 commit into puppetlabs:master from rodjek:pdk-1180

Nov 26, 2018

Contributor

rodjek commented Nov 26, 2018

The existing code doesn't handle the case where it is explicitly defined as null in metadata.json.


          (PDK-1180) Cleanly handle a null pdk_version in metadata.json

coveralls commented Nov 26, 2018

Coverage remained the same at 92.994% when pulling 8403605 on rodjek:pdk-1180 into 387ff02 on puppetlabs:master.

bmjen approved these changes

View reviewed changes

bmjen merged commit 9c64f28 into puppetlabs:master

bmjen added the bug label

rodjek deleted the pdk-1180 branch

November 26, 2018 23:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug