(PDK-1204) pdk bundle execs in the context of the pwd #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `:pwd` context to `PDK::CLI::Exec` that behaves the same as the `:module` context in that it sets up the Ruby environment to use the vendored libraries, but it runs the command from the working directory rather than the module root.
bmjen
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
:pwdcontext toPDK::CLI::Execthat behaves the same asthe
:modulecontext in that it sets up the Ruby environment to use thevendored libraries, but it runs the command from the working directory
rather than the module root.
This makes
pdk bundle execbehave more likebundle exec.