(IMAGES-1037) Make sure our paths are used

[mihaibuzgau]

No description provided.

[coveralls]

Coverage remained the same at 92.899% when pulling b9439cb on mihaibuzgau:master into 09688a6 on puppetlabs:master.

[mihaibuzgau]

To test this fix, I've downloaded the pdk MSI from here: https://builds.delivery.puppetlabs.net/pdk/2150ab39cb0fb2894041bd33df0d3379f37358e3/artifacts/windows/pdk-x64.msi
Edited the following file on the windows box: C:\Program Files\Puppet Labs\DevelopmentKit\private\ruby\2.4.5\lib\ruby\gems\2.4.0\gems\pdk-1.10.0.pre\lib\pdk\cli\exec.rb

Executed pdk validate on the motd module:

PS C:\Users\Administrator\ion\puppetlabs-motd> pdk validate
pdk (WARN): This module is compatible with an older version of PDK. Run `pdk update` to update it to your version of PDK.
pdk (INFO): Running all available validators...
pdk (INFO): Using Ruby 2.5.3
pdk (INFO): Using Puppet 6.2.0
[*] Installing missing Gemfile dependencies.
[*] Checking metadata syntax (metadata.json tasks/*.json).
[*] Checking module metadata style (metadata.json).
[*] Checking YAML syntax (["**/*.yaml", "*.yaml", "**/*.yml", "*.yml"]).
[*] Checking Puppet manifest syntax (**/**.pp).
[*] Checking Puppet manifest style (**/*.pp).
[*] Checking Ruby code style (**/**.rb).
info: task-name: ./: Target does not contain any files to validate (tasks/**/*).
info: task-metadata-lint: ./: Target does not contain any files to validate (tasks/*.json).

[mihaibuzgau]

/cc @bmjen

[bmjen]

This looks good to me.

[scotje]

Good catch! Yeah I think the intent was always for the parent PATH to be lowest precedence, probably when the git_paths were added it was just accidentally tacked onto the end.