Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1345) Disable analytics during package tests #670

Merged
merged 1 commit into from
May 30, 2019
Merged

(PDK-1345) Disable analytics during package tests #670

merged 1 commit into from
May 30, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented May 30, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.373% when pulling b2afa43 on rodjek:pdk-1345 into c026077 on puppetlabs:master.

scotje
scotje approved these changes May 30, 2019
View reviewed changes
package-testing/spec/spec_helper_package.rb
@@ -6,6 +6,8 @@
let(:path) { windows_node? ? nil : "#{install_dir}/bin:$PATH" }
end

set :env, PDK_DISABLE_ANALYTICS: 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a minute to figure out that set came from the specinfra gem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the specinfra gem is pretty terribly documented

@scotje scotje merged commit b0c642b into puppetlabs:master May 30, 2019
@rodjek rodjek deleted the pdk-1345 branch June 6, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodjek @coveralls @scotje @chelnak