(PDK-1333) Fix command_spec rake task for newer CRI versions #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the command_spec rake task only worked for older CRI version (<= 2.11.0) because the cri_options used to be passed as a hash, but is now it's own object type. This commit updates the conversion process to optionally convert the object to hash on newer CRI versions.
rodjek
approved these changes
Jul 3, 2019
|
Thought versions would be more "correct". But comparing on object type is ok too. Particularly as this "broke" API compatibility in a minor version bump 2.11.0 -> 2.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the command_spec rake task only worked for older CRI version
(<= 2.11.0) because the cri_options used to be passed as a hash, but is now it's
own object type. This commit updates the conversion process to optionally
convert the object to hash on newer CRI versions.