(PDK-1487) Add --default-template flag to pdk convert #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a simple flag for users to convert their module to the default template. ``` pdk convert --default-template ``` is functionally equivalent to ``` pdk convert --template-url https://github.com/puppetlabs/pdk-templates ``` Additionally, it clears the saved `template-url` value so that future operations will use the default template by default.
glennsarti
reviewed
Dec 9, 2019
| if opts[:'default-template'] | ||
| raise PDK::CLI::ExitWithError, _('You can not specify --template-url and --default-template.') if opts[:'template-url'] | ||
|
|
||
| opts[:'template-url'] = PDK::Util::TemplateURI.default_template_addressable_uri.to_s |
There was a problem hiding this comment.
Should this be resetting template-ref as well?
There was a problem hiding this comment.
I thought that being able to do something like pdk convert --default-template --template-ref 1.14.0 might be useful, so I left --template-ref alone. In terms of the saved ref in the answer file, it's stored as the fragment of the template-url uri, so it gets reset automatically for free.
glennsarti
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple flag for users to convert their module to the default
template.
is functionally equivalent to
Additionally, it clears the saved
template-urlvalue so that futureoperations will use the default template by default.