(PDK-1588) Increase granularity of pdk bundle analytics
#827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, when a user ran a `pdk bundle` command we would only
report a `bundle` screen view to our analytics. This resulted in us
finding out that a lot of users use `pdk bundle` but provided no insight
into why.
When a user runs `pdk bundle`, we will now capture the bundler
subcommand (but not any of the other arguments). The only exception to
this is if the user runs `pdk bundle exec` in which case we will also
capture the name of the command that is being executed (but again, none
of the arguments).
e.g.
* `pdk bundle show some_gem` will now be reported as a `bundle_show`
screen view.
* `pdk bundle exec rspec path/to/some/ruby_spec.rb` will now be
reported as a `bundle_exec_rspec` screen view.
glennsarti
reviewed
Jan 16, 2020
| end | ||
|
|
||
| before(:each) do | ||
| mock_command = instance_double( |
There was a problem hiding this comment.
All this mocking is a bit of a smell, but that's not for this PR.
glennsarti
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, when a user ran a
pdk bundlecommand we would onlyreport a
bundlescreen view to our analytics. This resulted in usfinding out that a lot of users use
pdk bundlebut provided no insightinto why.
When a user runs
pdk bundle, we will now capture the bundlersubcommand (but not any of the other arguments). The only exception to
this is if the user runs
pdk bundle execin which case we will alsocapture the name of the command that is being executed (but again, none
of the arguments).
e.g.
pdk bundle show some_gemwill now be reported as abundle_showscreen view.
pdk bundle exec rspec path/to/some/ruby_spec.rbwill now bereported as a
bundle_exec_rspecscreen view.