Add ability to generate functions #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests are failing with unrelated rubocop errors on Rakefile and config.rb |
DavidS
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Code looks good to me.
I would only suggest reverting the version number change as 1) the actual version will be determined during the release process and 2) this new feature would require a minor, not a patch-level bump.
I'm going to merge the associated pdk-templates changes so we can run this through our internal pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this can be merged the the following PR will need to be accepted.
puppetlabs/pdk-templates#379
I added tests but they don't seem to actually get executed which is puzzling. Guessing there is some undocumented tribal knowledge.
Some screen shots of the new function ality.