(CAT-1488) - Fix rubocop warnings #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavindidrichsen
changed the title
gavindidrichsen
force-pushed
the
cat_1488_updating_rubocop_warnings
branch
from
cce39c5
to
4ea249d
Compare
gavindidrichsen
force-pushed
the
cat_1488_updating_rubocop_warnings
branch
2 times, most recently
from
24450f3
to
493e2f7
Compare
gavindidrichsen
force-pushed
the
cat_1488_updating_rubocop_warnings
branch
from
493e2f7
to
e3a7006
Compare
Why? ``Rspec/FilePath`` is going to be deprecated in the next major release of rubocop >=3.0.0: see <https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath>. As the new cops are already present, e.g., Rspec/SpecFilePathPathFormat, then disabling this in preparation. NOTE: I've added this to the bottom of ``rubocop_baseline.yml`` to highlight that it is deprecated. Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
gavindidrichsen
force-pushed
the
cat_1488_updating_rubocop_warnings
branch
from
c074506
to
284dc12
Compare
ekohl
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Makes sense to me. I'd stick to wrapping the body of the commit message per https://cbea.ms/git-commit/#wrap-72 but that may be for others to decide on.
jordanbreen28
approved these changes
Oct 3, 2023
3 tasks
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes CI by excluding the soon-to-be deprecated Rspec/FilePath.
Additional Context
During investigation and after running
bundle exec rubocop --format github2 simultaneous warnings were observedRspec/FilePath(deprecated) andRspec/SpecFilePathFormat:The warning seem to be expecting a
puppet_lintdirectory rather than the currentpuppet-lintone. After excluding the deprecatedRspec/FilePathcop, then the rubocop warnings cleared.Since this cop is going to be deprecated in the next major release of rubocop >=3.0.0 according to the documentation, I've:
rubocop_baseline.ymlto highlight that it is deprecated; andChecklist