(FM-8178) Make params passable using provision.yaml #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
previously requested changes
Jun 18, 2019
There was a problem hiding this comment.
@michaeltlombardi ++ for the functionality.
it needs rubocop-ified.
and we do need to document this somewhere . though this is not the time for it. yet.
Prior to this commit the only way to pass additional provisioning params to a provisioning task was via environment variables. This commit adds an optional params hash to the provision.yaml definition, enabling a user to pass an arbitrary set of keys to the provisioner. These are transformed into environment variables as `LITMUS_param` where the `param` is upcased. This will enable users of the vagrant provisioner on windows to pass SMB username and passwords via the provision file instead of typing them into the terminal. The environment variables created during the run do not persist outside of the ruby runspace.
michaeltlombardi
deleted the
ticket/master/FM-8178-params-via-provision-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the only way to pass additional provisioning params
to a provisioning task was via environment variables. This commit adds
an optional params hash to the provision.yaml definition, enabling a
user to pass an arbitrary set of keys to the provisioner.
These are transformed into environment variables as
LITMUS_paramwherethe
paramis upcased. This will enable users of the vagrant provisioneron windows to pass SMB username and passwords via the provision file
instead of typing them into the terminal.
The environment variables created during the run do not persist outside
of the ruby runspace.