(FM-8611) Reinstall module #209
Conversation
|
Depends on #208 |
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
- Coverage 59.62% 59.5% -0.13%
=========================================
Files 6 6
Lines 535 563 +28
=========================================
+ Hits 319 335 +16
- Misses 216 228 +12
Continue to review full report at Codecov.
|
florindragos
force-pushed
the
reinstall-module
branch
2 times, most recently
from
09d79f6
to
2b528d9
Compare
|
Should this be rebased on master now that the rake task refactor is merged, @florindragos? |
florindragos
force-pushed
the
reinstall-module
branch
from
2b528d9
to
4837fe6
Compare
done |
lib/puppet_litmus/rake_helper.rb
Outdated
| @@ -184,4 +184,21 @@ def install_module(inventory_hash, target_node_name, module_tar) | |||
| install_module_command = "puppet module install /tmp/#{File.basename(module_tar)}" | |||
| run_command(install_module_command, target_nodes, config: nil, inventory: inventory_hash) | |||
| end | |||
|
|
|||
| def uninstall_module(inventory_hash, target_node_name) | |||
There was a problem hiding this comment.
Should this be more generically able to uninstall any given module? Then we could specify metadata_module_name to remove that one or any of the dependencies or other modules.
There was a problem hiding this comment.
It could default to uninstalling the working directory's module, I think.
There was a problem hiding this comment.
We could do that but I'm not sure what the use case for this would be.
There was a problem hiding this comment.
Uninstalling dependencies to check behavior is the first thing that comes to mind.
There was a problem hiding this comment.
Added a a parameter for the module name but if we want to uninstall dependencies, we need to use --force
florindragos
force-pushed
the
reinstall-module
branch
from
4837fe6
to
43bace3
Compare
lib/puppet_litmus/rake_tasks.rb
Outdated
| # Reinstall the puppet module under test on a collection of nodes | ||
| # | ||
| # @param :target_node_name [Array] nodes on which to install a puppet module for testing. | ||
| desc 'reinstall_module - reinstgall module' |
florindragos
force-pushed
the
reinstall-module
branch
from
43bace3
to
a357548
Compare
No description provided.