Fixes undefined method facts_from_node error from 0.18.0
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases litmus usage would not make facts_from_node available in the namespace add_platform_field sees. Specifically differences in spec_helper_acceptance would change that. This change adjusts unit testing to how `configure!` initialises the namespaces, fixes the unit tests and moves the previously separate HoneycombUtils into InventoryManipulation, where it has the necessary visibility. Closes puppetlabs#280.
Closed
|
Validation of this fix running in puppetlabs/puppetlabs-motd#299 |
sheenaajay
approved these changes
Apr 2, 2020
DavidS
changed the title
undefined method error from 0.18.0undefined method facts_from_node error from 0.18.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold in add_platform_field to where it can access facts_from_node
In some cases litmus usage would not make facts_from_node available in the namespace add_platform_field sees. Specifically differences in spec_helper_acceptance would change that.
This change adjusts unit testing to how
configure!initialises the namespaces, fixes the unit tests and moves the previously separate HoneycombUtils into InventoryManipulation, where it has the necessary visibility.Closes #280.