Use default working directory for all uploads to SUTs #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `/tmp` as upload target meant that `install_module` and `create_manifest_file` would not work with windows SUTs, which do not have that directory. This changes those methods to not use any directory, dumping files into the default user's home directory instead. Fixes: puppetlabs#249
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 62.87% 62.95% +0.08%
==========================================
Files 7 7
Lines 765 764 -1
==========================================
Hits 481 481
+ Misses 284 283 -1
Continue to review full report at Codecov.
|
|
There's something wonky with travis going on. The "queue" Travis check is a duplicate of the successful one. 🤷 |
|
LGTM. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
/tmpas upload target meant thatinstall_moduleandcreate_manifest_filewould not work with windows SUTs, which donot have that directory.
This changes those methods to not use any directory, dumping files
into the default user's home directory instead.
Fixes: #249