Calculate github actions job matrix from metadata.json; fix frozen-string modification in puppet_output #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
matrix
branch
4 times, most recently
from
d6543bb
to
8765f3e
Compare
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 63.34% 63.34%
=======================================
Files 7 7
Lines 802 802
=======================================
Hits 508 508
Misses 294 294
Continue to review full report at Codecov.
|
DavidS
changed the title
4 tasks
ekohl
reviewed
Oct 28, 2020
The `matrix_from_metadata` executable supports creating a platform matrix for the new cloud-ci project based off the `metadata.json` in the current module.
To avoid various testing efforts colliding, puppet_litmus always needs to test against the local PR's branch and remove any other puppet_litmus declarations in MOTD's Gemfile.
`bolt_result` seems to be a frozen string now, so don't unnecessarily try to modify it. Instead create a new string.
carabasdaniel
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
matrix_from_metadataexecutable supports creating a platformmatrix for the new cloud-ci project based off the
metadata.jsonin the current module.