Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix append_cli parameters #344

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix append_cli parameters #344

merged 1 commit into from
Nov 30, 2020

Conversation

hajee
Copy link
Contributor

@hajee hajee commented Nov 24, 2020

The docker_ext provisioner support's having extra cli parameters. This support has been lost in the caller. This PR reimplements this.

@hajee hajee requested a review from a team as a code owner November 24, 2020 13:34
@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #344 (ee2d720) into main (01cb5f5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   62.36%   62.40%   +0.04%     
==========================================
  Files           7        7              
  Lines         813      814       +1     
==========================================
+ Hits          507      508       +1     
  Misses        306      306              
Impacted Files Coverage Δ
lib/puppet_litmus/rake_helper.rb 74.77% <100.00%> (+0.11%) ⬆️
lib/puppet_litmus/rake_tasks.rb 29.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cb5f5...ee2d720. Read the comment docs.

@hajee
Copy link
Contributor Author

hajee commented Nov 25, 2020

Can somebody please help and see why the tests fail? I don't see any message that I can link to the change I did.

@DavidS
Copy link
Contributor

DavidS commented Nov 26, 2020

Here is your error: https://travis-ci.com/github/puppetlabs/puppet_litmus/jobs/447303410#L1309

I'm pushing a fix for travis to show/detect that better at 5d532c9

If you had enabled "Allow edits from maintainers" I could have added it here to have you be able to work with it directly.

@hajee
Copy link
Contributor Author

hajee commented Nov 26, 2020

Thanks David. I'll fix it.

Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this patch!

@michaeltlombardi michaeltlombardi self-assigned this Nov 30, 2020
@michaeltlombardi michaeltlombardi merged commit d614fe3 into puppetlabs:main Nov 30, 2020
@hajee
Copy link
Contributor Author

hajee commented Nov 30, 2020

My pleasure. Is there an ETA when this will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants