(CONT-193) Always build parallel task #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit `litmus::acceptance` would check for the existance of litmus_inventory before building the `parallel` task. If the file is not present then the task would not be build and not available in the list of tasks (`bundle exec rake --tasks`). It appears that tasks are only evaluated at Runtime. This causes an issue when calling tasks sequentially inside a task via the api. In this particular case, the litmus_inventory file is only present after the provision task has executed. This means that the task list would have already been built without the acceptance task. This would result in the following error: `Don't know how to build task 'litmus:acceptance:parallel' (see --tasks)` This commit removes the check so that the task can always be built. Checking for the existance of the `litmus_inventory` file is now scoped around where we dynamically build tasks based on the nodes listed in the inventory file.
Codecov ReportBase: 64.30% // Head: 64.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 64.30% 64.66% +0.35%
==========================================
Files 7 7
Lines 919 917 -2
==========================================
+ Hits 591 593 +2
+ Misses 328 324 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
david22swan
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit
litmus::acceptancewould check for the existance of litmus_inventory before building theparalleltask.If the file is not present then the task would not be build and not available in the list of tasks (
bundle exec rake --tasks). It appears that tasks are only evaluated at Runtime.This causes an issue when calling tasks sequentially inside a task via the api. In this particular case, the litmus_inventory file is only present after the provision task has executed. This means that the task list would have already been built without the acceptance task.
This would result in the following error:
Don't know how to build task 'litmus:acceptance:parallel' (see --tasks)This commit removes the check so that the task can always be built. Checking for the existance of the
litmus_inventoryfile is now scoped around where we dynamically build tasks based on the nodes listed in the inventory file.