fix docker build by forcing older version of public_suffix #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
hey @gmenuel, thanks again for this! For posterity, I'm making the same comment I did on the corresponding puppetserver PR: Unfortunately, it has been decided that we will no longer be maintaining docker images for Puppet's projects. If you have tested this change and are satisfied that it solves your problem, I am happy to merge this pull request, but please be aware that we at Puppet will not be doing any additional testing of this change and we will not be fixing any bugs that may arise as a result of this, or any other changes. If you would still like me to merge this, let me know! Otherwise, this PR will be closed in a few weeks. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to a PR I've done on puppetserver puppetlabs/puppetserver#2670
Currently docker build fail with the following error:
This PR fix this by forcing the public_suffix ruby gem to 4.0.7