Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10763) Remove frequency collector #1010

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

LTangaF
Copy link

@LTangaF LTangaF commented Oct 7, 2021

The case logic in apt::update adequately covers the 'always' case and
the collector causes issues in acceptance testing.

The case logic in apt::update adequately covers the 'always' case and
the collector causes issues in acceptance testing.
@LTangaF LTangaF requested a review from a team as a code owner October 7, 2021 16:59
@puppet-community-rangefinder
Copy link

apt is a class

that may have no external impact to Forge modules.

This module is declared in 233 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2021

CLA assistant check
All committers have signed the CLA.

@LTangaF
Copy link
Author

LTangaF commented Oct 7, 2021

If it is recommended to open a separate ticket to associate this to, let me know.

@daianamezdrea
Copy link

Hi @LTangaF I approved the tests run, let's see how it's working

@daianamezdrea
Copy link

Hi @LTangaF, this looks good, thank you for your contribution !

@daianamezdrea daianamezdrea merged commit 6fa24e6 into puppetlabs:main Oct 18, 2021
@LTangaF
Copy link
Author

LTangaF commented Oct 18, 2021

Thank you. How do I track when this ends up in a version published on forge?

@kenyon
Copy link

kenyon commented Oct 18, 2021

Thank you. How do I track when this ends up in a version published on forge?

@LTangaF you can use GitHub’s “watch” feature to receive notifications about everything happening in this repo, or you can use https://newreleases.io/ to receive only notifications about new releases.

@LTangaF LTangaF deleted the remove_frequency_collector branch October 19, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants