Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Fix resource ordering when apt-transport-https is needed #1015

Merged
merged 1 commit into from
Feb 21, 2022
Merged

(maint) Fix resource ordering when apt-transport-https is needed #1015

merged 1 commit into from
Feb 21, 2022

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Feb 17, 2022

On older Debian / Ubuntu releases, the apt-transport-https package is
required to download from an https:// source. This package dependency
is ensured by ensure_packages() but no ordering is set, possibly
resulting of the resource being applied in a non-working order:

  1. Setup a https:// source
  2. Trigger apt update (this will fail)
  3. Install apt-transport-https

Add a dependency to ensure apt-transport-https is installed when the
repositories are updated.

@smortex
(maint) Fix resource ordering when apt-transport-https is needed
0ca3c30 
On older Debian / Ubuntu releases, the apt-transport-https package is
required to download from an https:// source.  This package dependency
is ensured by ensure_packages() but no ordering is set, possibly
resulting of the resource being applied in a non-working order:

1. Setup a https:// source
2. Trigger apt update (this will fail)
3. Install apt-transport-https

Add a dependency to ensure apt-transport-https is installed when the
repositories are updated.
@puppet-community-rangefinder
Copy link

apt::source is a type

Breaking changes to this file WILL impact these 336 modules (exact match):
Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 234 of 578 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@smortex smortex marked this pull request as ready for review February 17, 2022 01:52
@smortex smortex requested a review from a team as a code owner February 17, 2022 01:52
@LukasAud LukasAud merged commit 966ca80 into main Feb 21, 2022
@LukasAud LukasAud deleted the apt-transport-https-ordering branch February 21, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smortex @kenyon @bastelfreak @LukasAud