Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-11301) Don't install gnupg if not needed #1020

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

simondeziel
Copy link

apt::key has the needed ensure_packages() to bring gnupg only
when needed.

Signed-off-by: Simon Deziel simon@sdeziel.info

apt::key has the needed ensure_packages() to bring gnupg only
when needed.

Signed-off-by: Simon Deziel <simon@sdeziel.info>
@simondeziel simondeziel requested a review from a team as a code owner March 17, 2022 03:35
@puppet-community-rangefinder
Copy link

apt is a class

Breaking changes to this file WILL impact these 245 modules (exact match):
Breaking changes to this file MAY impact these 47 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2022

CLA assistant check
All committers have signed the CLA.

@chelnak
Copy link

chelnak commented Mar 22, 2022

Hey @simondeziel, Thank you for your contribution! Please could you sign the CLA when you get a spare second then we can progress with this PR.

@simondeziel
Copy link
Author

Please let me know if something's missing to get that merged, thanks!

@chelnak
Copy link

chelnak commented Mar 28, 2022

Your change makes sense to me 😄

@chelnak chelnak merged commit dbf8861 into puppetlabs:main Mar 28, 2022
@simondeziel simondeziel deleted the optional-gnupg branch March 28, 2022 20:40
@simondeziel
Copy link
Author

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants