forked from evolvingweb/puppet-apt
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-11301) Don't install gnupg if not needed #1020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apt::key has the needed ensure_packages() to bring gnupg only when needed. Signed-off-by: Simon Deziel <simon@sdeziel.info>
kenyon
approved these changes
Mar 17, 2022
Hey @simondeziel, Thank you for your contribution! Please could you sign the CLA when you get a spare second then we can progress with this PR. |
Please let me know if something's missing to get that merged, thanks! |
Your change makes sense to me 😄 |
chelnak
approved these changes
Mar 28, 2022
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apt::key has the needed ensure_packages() to bring gnupg only
when needed.
Signed-off-by: Simon Deziel simon@sdeziel.info