Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ISSUE-1036) Conditional gnupg include added to init.pp #1039

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

david22swan
Copy link
Member

Originally removed as it was causing gnupg to be installed in all OS when it wasn't needed, removing it seems to have caused a dependency cycle in the relevant Debian family OS for certain community members.
Adding the include back within a conditional statement to solve the issue while still preventing it from being included when unneeded.

Originally removed as it was causing `gnupg` to be installed in all OS when it wasn't needed, removing it seems to have caused a dependency cycle in the relevant Debian family OS for certain community members.
Adding the include back within a conditional statement to solve the issue while still preventing it from being included when unneeded.
@david22swan david22swan requested a review from a team as a code owner June 20, 2022 10:10
@puppet-community-rangefinder
Copy link

apt is a class

Breaking changes to this file WILL impact these 246 modules (exact match):
Breaking changes to this file MAY impact these 48 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@chelnak chelnak merged commit a03ae3f into puppetlabs:main Jun 20, 2022
@david22swan david22swan deleted the GH-1036/main/dependency_cycle branch July 27, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants