(GH-1038) add support for check-valid-until configuration
#1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fitzy101 Could you have a look at this and see if it was what you had in mind? |
bastelfreak
reviewed
Jul 28, 2022
bastelfreak
previously approved these changes
Jul 28, 2022
fitzy101
suggested changes
Aug 3, 2022
There was a problem hiding this comment.
Hi @david22swan apologies for the delayed response. Thanks for looking at this configuration option. The current implementation doesn't quite address the problem, as the syntax isn't correct for setting the check-valid-until option inline.
If I manually set the value like in the commit, you can see the apt update command fails.
~ # cat /etc/apt/sources.list.d/debian-security-snapshot.list
deb [Acquire::Check-Valid-Until=false] https://snapshot.debian.org/archive/debian-security/20220612T175238Z/ bullseye-security main
~ # apt update
# ...
Hit:4 https://snapshot.debian.org/archive/debian-security/20220612T175238Z bullseye-security InRelease
Reading package lists... Done
E: Release file for https://snapshot.debian.org/archive/debian-security/20220612T175238Z/dists/bullseye-security/InRelease is expired (invalid since 44d 8h 26min 50s). Updates for this repository will not be applied.
# ...
The format should be [check-valid-until=no], which you can see in the example below.
~ # cat /etc/apt/sources.list.d/debian-security-snapshot.list
deb [check-valid-until=no] https://snapshot.debian.org/archive/debian-security/20220612T175238Z/ bullseye-security main
~ # apt update
#...
Hit:4 https://snapshot.debian.org/archive/debian-security/20220612T175238Z bullseye-security InRelease
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
5 packages can be upgraded. Run 'apt list --upgradable' to see them.
Add's additional configuration to `apt::source` to allow the user to specify whether or not to check if the repository that they are accessing has a valid release ate. Defaults to `True`
david22swan
force-pushed
the
GH-1038/main/check_valid_until
branch
from
54468f3 to
3d3620c
Compare
|
@fitzy101 That's the update made, thanks for getting back to me on it |
fitzy101
approved these changes
Aug 3, 2022
That’s great, thanks. |
LukasAud
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add's additional configuration to
apt::sourceto allow the user to specify whether or not to check if the repository that they are accessing has a valid release ate.Defaults to
True