Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with net-ftp being unavailable #1050

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Aug 10, 2022

In Ruby 3.0 net-ftp changed from a bundled gem to a default gem. This means it may not be available, such as when running unit tests.

Since ftp is becoming less and less common, this changes net-ftp to be an optional dependency. Users who do need ftp support should ensure the gem is installed.

In Ruby 3.0 net-ftp changed from a bundled gem to a default gem. This
means it may not be available, such as when running unit tests.

Since ftp is becoming less and less common, this changes net-ftp to be
an optional dependency. Users who do need ftp support should ensure the
gem is installed.
@chelnak chelnak merged commit 8b15f6f into puppetlabs:main Aug 17, 2022
@chelnak
Copy link

chelnak commented Aug 17, 2022

@ekohl Thank you 👍

@joshcooper
Copy link

The require 'net/ftp' gem should really be moved into the source_to_file method to properly handle this. Some context, if you're not using puppet generate types, then puppetserver will load types and providers and call the type's title_patterns method. Agent-side code like require 'net/ftp' needs to be guarded so it's only invoked on the agent, and not during compilation.

@chelnak
Copy link

chelnak commented Feb 28, 2023

Thanks @joshcooper .. I'll raise this with the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants