(GH-1055) Fix hardcoded cache path #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the cache path used to create the script file resource was hardcoded to /opt/puppetlabs/puppet/cache. This commit fixes that by using the `puppet_vardir` fact provided by stdlib so that we will always get the correct path for the OS that is executing the code. Additionally, if for some reason the `puppet_vardir` fact is not available we will fall back to `tmp`.
chelnak
force-pushed
the
gh-1055-hardcoded_cache_path
branch
from
fee500e to
58265f3
Compare
LukasAud
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the cache path used to create the script file resource was hardcoded to
/opt/puppetlabs/puppet/cache.This PR fixes that by using the
puppet_vardirfact provided by stdlib so that we will always get the correct path for the OS that is executing the code.Additionally, if for some reason the
puppet_vardirfact is not available we will fall back totmp.Fixes #1055