(GH-1057) Regex fix to allow dotted resources #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
suggested changes
Aug 30, 2022
Prior to this commit, one of our recent module updates introduced a regex validation step for the resource names in our ppa.pp manifest which would raise an issue if a valid resource name contained a dot (.). This commit aims to slightly adjust the regex validation so that it allows for dotted resource names. This PR should fix issue #1057.
chelnak
changed the title
chelnak
suggested changes
Aug 31, 2022
Prior to this commit, ppa_spec.rb did not test the recently implemented validation for resource names. This commit aims to implement some test cases to make sure that valid resource names are allowed while invalid or malicious resource names do not work.
chelnak
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, one of our recent module updates introduced a
regex validation step for the resource names in our ppa.pp manifest
which would raise an issue if a valid resource name contained a dot (.).
This commit aims to slightly adjust the regex validation so that it
allows for dotted resource names. This PR should fix issue #1057.