Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove PPA sources.list.d files if purge is enabled #1069

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Do not remove PPA sources.list.d files if purge is enabled #1069

merged 3 commits into from
Oct 31, 2022

Conversation

Programie
Copy link

As described in #1064, if enabling purge for sources.list.d, files created by add-apt-repository executed by apt::ppa are removed and re-added on the next Puppet run.

This PR should fix that issue by adding a file resource for the sources.list.d file created by add-apt-repository.

@Programie Programie requested a review from a team as a code owner October 25, 2022 14:40
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

apt::ppa is a type

Breaking changes to this file WILL impact these 68 modules (exact match):
Breaking changes to this file MAY impact these 10 modules (near match):

This module is declared in 234 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants