Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mark as title can contain dot (fixes #1074) #1075

Merged
merged 8 commits into from
Jan 18, 2023

Conversation

xepa
Copy link

@xepa xepa commented Dec 12, 2022

ubuntu packages can contain dots in the name, like: containerd.io

@xepa xepa requested a review from a team as a code owner December 12, 2022 14:26
@puppet-community-rangefinder
Copy link

apt::mark is a type

that may have no external impact to Forge modules.

This module is declared in 235 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

kenyon
kenyon previously approved these changes Dec 12, 2022
Copy link

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes commit eed10ea and issue #1074.

kenyon
kenyon previously approved these changes Dec 21, 2022
@LukasAud
Copy link

LukasAud commented Jan 9, 2023

Hi @xepa, sorry for the delay in feedback. It looks like your bugfix is not passing some of our unit tests. This needs to be addressed before we can merge your PR.

@xepa
Copy link
Author

xepa commented Jan 9, 2023

Hi @xepa, sorry for the delay in feedback. It looks like your bugfix is not passing some of our unit tests. This needs to be addressed before we can merge your PR.

Ah I noticed also .. seems that there are some tests that use invalid debian package names and they are expected to succeed .. (for instance the tests assume that my_source is a valid package name according to the manual its not valid)

@xepa
Copy link
Author

xepa commented Jan 11, 2023

Hi @LukasAud I reread the policy and found some edge cases not covered before (updated regex again) and updated the unit tests, they should now all pass.

Copy link

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@LukasAud LukasAud merged commit fad371f into puppetlabs:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants