-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated mark as title can contain dot (fixes #1074) #1075
Conversation
apt::mark is a typethat may have no external impact to Forge modules. This module is declared in 235 of 580 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now using debian policy manual as reference
Hi @xepa, sorry for the delay in feedback. It looks like your bugfix is not passing some of our unit tests. This needs to be addressed before we can merge your PR. |
Ah I noticed also .. seems that there are some tests that use invalid debian package names and they are expected to succeed .. (for instance the tests assume that my_source is a valid package name according to the manual its not valid) |
Hi @LukasAud I reread the policy and found some edge cases not covered before (updated regex again) and updated the unit tests, they should now all pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution.
ubuntu packages can contain dots in the name, like: containerd.io