fix: remove apt:: prefix from fact variables

[johanfleury]

Fact variables are top-scopped and should not be prefixed by module name.

This bug was introduced by cb6e58c.

[puppet-community-rangefinder]

apt::update is a class

Breaking changes to this file WILL impact these 17 modules (exact match):

• locp-cassandra
• midonet-midonet
• puppet-cassandra
• midonet-cassandra
• hfm-percona
• locp-opscenter
• praekeltfoundation-xylem
• praekeltfoundation-gluster
• praekeltfoundation-consular
• poolski-beats
• bltavares-baseline
• wavesoftware-xtreemfs
• narasimhasv-docker
• narasimhasv-lxc
• locp-odoo
• locp-odoo9
• hfm-h2o

Breaking changes to this file MAY impact these 9 modules (near match):

• hfm-stns
• puppetlabs-openstack
• meltwater-marathon
• hfm-tinyproxy
• jtopjian-cubbystack
• hfm-proxysql
• narasimhasv-openstack
• factorit-icingaweb2
• hfm-octopass

This module is declared in 235 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[johanfleury]

@pmcmaw I’m pinging you as you’re the one who published the previous release: once this PR is merged, could you please make a new release as soon as possible?

Release v9.0.1 is broken with: Server Error: Evaluation Error: Unknown variable: 'apt::apt_update_last_success'. (file: /etc/puppetlabs/code/environments/production/modules/apt/manifests/update.pp, line: 21, column: 10).

[johanfleury]

@kenyon thanks for the review, your suggestions make sense. Let me know if there’s anything else I should change.

[david22swan]

LGTM