Adopt new parameter defaults in template #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the apt::pin define has switched from empty string to Undef. But the template was not updated. fixes puppetlabs#1089
|
I wonder if undef is the right default to set here? I know there were conversations around this yesterday.. interested in your thoughts. |
Hi @chelnak I just adopted the template to the new parameter defaults. |
|
Hi @chelnak can we continue with this PR? |
|
Hey sure, sorry about the wait. I went over your changes again and am happy. |
chelnak
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the apt::pin define has switched from empty string to Undef. But the template was not updated.
fixes #1089