Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-1028) puppetlabs/stdlib: Allow 9.x #1113

Conversation

bastelfreak
Copy link
Collaborator

this is a resubmission of #1111

@bastelfreak bastelfreak requested a review from a team as a code owner June 5, 2023 07:13
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bastelfreak
❌ LukasAud
You have signed the CLA already but the status is still pending? Let us recheck it.

@bastelfreak bastelfreak force-pushed the pdksync_CONT-1028-update-stdlib-dependency branch from 6a481a7 to c0b8640 Compare June 5, 2023 07:55
Copy link

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this contribution!

@LukasAud LukasAud merged commit 6c53cb7 into puppetlabs:main Jun 5, 2023
@bastelfreak bastelfreak deleted the pdksync_CONT-1028-update-stdlib-dependency branch June 5, 2023 09:34
@bastelfreak
Copy link
Collaborator Author

@LukasAud thanks for the quick merge! Is it possible to get a new release soon?

@@ -10,7 +10,7 @@
"dependencies": [
{
"name": "puppetlabs/stdlib",
"version_requirement": ">= 4.16.0 < 9.0.0"
"version_requirement": ">= 4.16.0 < 10.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, stdlib::ensure_packages appeared in 9.0.0 (where merge is also available as stdlib::merge). Not sure if we should bump the minimum version to 9.0.0 or rather use the deprecated functions.

Copy link
Collaborator Author

@bastelfreak bastelfreak Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to do it now and rip out all the legacy function calls. Otherwise we need to touch the codebase in the future again.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! I opened #1114 to update the minimum version requirement.

@LukasAud
Copy link

LukasAud commented Jun 6, 2023

@bastelfreak We are working on releases. However, due to some recent maintenance, there is a lengthy task that we need to address before we can cut a release for each module. We will try to release as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants