Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "hourly" and Integer as value for update frequency (fixes #1157) #1159

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

webcompas
Copy link

Summary

With these changes the update frequency accepts two more values as described in the linked issue.

Related Issues

Add more possible values for update frequency (#1157)

Checklist

  • 🟢 Spec tests.
  • Manually verified.

@webcompas webcompas requested review from bastelfreak, smortex and a team as code owners December 21, 2023 11:18
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2023

CLA assistant check
All committers have signed the CLA.

@kenyon kenyon mentioned this pull request Jan 3, 2024
3 tasks
@smortex
Copy link
Collaborator

smortex commented Jan 3, 2024

CI failure is due to:

https://github.com/webcompas/puppetlabs-apt/blob/5265b132500c2d047cec777105f5764f17e79bad/spec/classes/apt_update_spec.rb#L177

Can be fixed by something like:

-          let(:pre_condition) { "class{ '::apt': update => {'frequency' => '#{update_frequency}',} }" }
+          let(:pre_condition) { "class{ '::apt': update => {'frequency' => #{update_frequency.inspect},} }" }

That globally look okay, but feel aggressive: IIRC the default configuration of unattended-updates only update twice a day, so anything more frequent than that feels too much to me. That being said, I am not a Debian developer and maybe those who are would consider this totally fine, so I would love to have someone from the Debian project to step in to help here make an informed decision.

@smortex smortex added the feature label Jan 3, 2024
@webcompas
Copy link
Author

Thanks for the hint to fix the spec tests. I implemented it and now they are running successfully.

@webcompas
Copy link
Author

Please review and merge.

@bastelfreak
Copy link
Collaborator

the ARM nightlies are broken, so I'm going to merge this.

@bastelfreak bastelfreak merged commit 3e364df into puppetlabs:main Feb 15, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants