Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 12 "bookworm" support #1178

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

kenyon
Copy link

@kenyon kenyon commented May 15, 2024

@kenyon kenyon requested review from bastelfreak, smortex and a team as code owners May 15, 2024 23:41
@kenyon kenyon changed the title Add Debian 12 support Add Debian 12 "https://github.com/puppetlabs/puppetlabs-apt/pull/1177" support May 15, 2024
@kenyon kenyon changed the title Add Debian 12 "https://github.com/puppetlabs/puppetlabs-apt/pull/1177" support Add Debian 12 "bookworm" support May 15, 2024
@kenyon
Copy link
Author

kenyon commented May 15, 2024

Not sure what needs to happen to resolve the agent installation failure on Debian 12 acceptance tests:

Installation of agent failed.
Results:
  1719e17324c7: {"_output"=>"23:44:29 +0000 INFO: Version parameter not defined and no agent detected. Assuming latest.\n23:44:29 +0000 INFO: Downloading Puppet latest for Debian...\n23:44:29 +0000 INFO: Debian platform! Lets get you a DEB...\n23:44:29 +0000 INFO: Downloading [http://nightlies.puppet.com/apt/puppet8-nightly-release-.deb\n23:44:29](http://nightlies.puppet.com/apt/puppet8-nightly-release-.deb/n23:44:29) +0000 INFO:   to file /tmp/install.sh.828.290040416/puppet8-nightly-release-.deb\n23:44:29 +0000 INFO: Trying wget...\n23:44:29 +0000 INFO: Retrying... [1/5]\n23:44:29 +0000 INFO: Return code: 8\n23:44:30 +0000 INFO: Retrying... [2/5]\n23:44:30 +0000 INFO: Return code: 8\n23:44:31 +0000 INFO: Retrying... [3/5]\n23:44:31 +0000 INFO: Return code: 8\n23:44:32 +0000 INFO: Retrying... [4/5]\n23:44:32 +0000 INFO: Return code: 8\n23:44:33 +0000 INFO: Retrying... [5/5]\n23:44:33 +0000 INFO: Return code: 8\n23:44:34 +0000 CRIT: ERROR 404\n23:44:34 +0000 CRIT: Unable to retrieve a valid package!\n", "_error"=>{"kind"=>"puppetlabs.tasks/task-error", "issue_code"=>"TASK_ERROR", "msg"=>"The task failed with exit code 1", "details"=>{"exit_code"=>1}}}}
/home/runner/work/puppetlabs-apt/puppetlabs-apt/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_helper.rb:335:in `raise_bolt_errors'
/home/runner/work/puppetlabs-apt/puppetlabs-apt/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_helper.rb:156:in `install_agent'
/home/runner/work/puppetlabs-apt/puppetlabs-apt/vendor/bundle/ruby/2.7.0/gems/puppet_litmus-1.4.0/lib/puppet_litmus/rake_tasks.rb:130:in `block (2 levels) in <top (required)>'
/home/runner/work/puppetlabs-apt/puppetlabs-apt/vendor/bundle/ruby/2.7.0/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/bundle:23:in `load'
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/bundle:23:in `<main>'
Tasks: TOP => litmus:install_agent

I guess a change in some litmus repo.

@smortex
Copy link
Collaborator

smortex commented May 16, 2024

http://nightlies.puppet.com/apt/puppet8-nightly-release-.deb
                                                        ^~~~

Should be something like:

http://nightlies.puppet.com/apt/puppet8-nightly-release-bookworm.deb

I have not the time to test ATM, but I think this is caused by:

puppet_agent:
repo: 'https://github.com/puppetlabs/puppetlabs-puppet_agent.git'
ref: v4.13.0

which does not include (added in 4.19.0):
puppetlabs/puppetlabs-puppet_agent@f99be19

Can you give it a try?

smortex
smortex previously approved these changes May 21, 2024
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I guess some work on the PR may be needed depending on the merge ordering, but this is great!

@Ramesh7 Ramesh7 dismissed smortex’s stale review June 14, 2024 12:07

The merge-base changed after approval.

@Ramesh7 Ramesh7 merged commit 8220df8 into puppetlabs:main Jun 14, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants