Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian: add non-free-firmware repo component #1180

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

kenyon
Copy link

@kenyon kenyon commented May 18, 2024

Debian 12 "bookworm" added the non-free-firmware repository component. This pull request adds that component to examples, tests, and backports for Debian 12. Reference: https://wiki.debian.org/Firmware

Includes #1174.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and the commit with the implementation looks good!

I will only click "Comment" and not "Approve" to avoid someone from unexpectedly merging cherry-picks from commits in other PRs, but consider this approved from my side ;-)

@kenyon kenyon force-pushed the non-free-firmware branch from 6c216f3 to 3ecb9e3 Compare June 15, 2024 18:11
kenyon added 3 commits October 3, 2024 23:44
Also includes some corrections to documentation.
Debian 12 "bookworm" added the non-free-firmware repository component.
This commit adds that component to examples, tests, and backports for
Debian 12. Reference: https://wiki.debian.org/Firmware
@kenyon kenyon force-pushed the non-free-firmware branch from 3ecb9e3 to 3c7161e Compare October 4, 2024 06:44
@bastelfreak bastelfreak merged commit c72aa14 into puppetlabs:main Oct 4, 2024
19 of 20 checks passed
@bastelfreak
Copy link
Collaborator

As we saw some breaking changes, puppetlabs/puppetlabs-puppet_agent#738, this shouldn't be marked as a feature I guess?

@bastelfreak
Copy link
Collaborator

@kenyon I think this introduced a regression: #1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants