proxy support for apt::ppa

[PierreGambarotto]

If the node is behind a proxy, the apt class has two parameters to describe the proxy configuration (proxy_host and proxy_port).

Due to a bug in add-apt-repository, the settings is ignored, and you must define the environment variable https_proxy. See launchpad bug for more details.

The code I propose modifies the environment of the exec resource if the apt class is defined with a proxy_host value different from the default (false).

[hunner]

I'm curious... would updating Acquire::http::proxy et al in /etc/apt/apt.conf as per https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/516032/comments/19 not be a more correct workaround?

[hunner]

Oh duh, never mind; that doesn't work and is why you submitted this PR.

[slamont]

I'm getting an error that I think maybe related to this code
Error: Parameter environment failed on Exec[add-apt-repository-ppa:formorer/icinga]: Invalid environment setting ''

Used like this:
apt::ppa { 'ppa:formorer/icinga': }

[slamont]

When removing this commit I got another error:
Error: Could not find dependency File[/etc/apt/sources.list.d] for Exec[add-apt-repository-ppa:formorer/icinga]

[PierreGambarotto]

You're right. The correct empty value for environment is the empty array [], and not the empty string "". I propose a pull request immediatly.

For your other problem, the dependancy File[/etc/apt/sources.list.d] is realized by the class apt itself.
So you have to include the apt class.

include apt
# or
class{apt:
}

[PierreGambarotto]

@slamont

Please test with #145

[slamont]

#145 Worked for me

Your other suggestion worked as expected (include apt).
I'm currently working on a fork of rendhalver/puppet-icinga and it seems that I'll have a little more work to do than expected ;)

[hunner]

Thanks for catching this @PierreGambarotto ! Sorry for the trouble.