Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: parametrize apt::ppa class for beign able to pass options to apt-add-repository command #146

Merged
merged 2 commits into from
Jul 17, 2013

Conversation

oleiade
Copy link

@oleiade oleiade commented Jul 16, 2013

Hi!

Using the puppetlabs-apt module on our platform we've noticed that even if we manualy added repositories keys before adding a launchpad repo using apt::ppa class, the operation would fail because apt-add-repository would ask for user input.

We've fixed the apt::ppa class to support a options parameter allowing to pass options to the underlying apt-add-repository execution. As a default 'options' is set to '-y' to avoid user prompt. We found it might be usefull to anyone so here's our pull request.

Thanks

@apenney
Copy link

apenney commented Jul 16, 2013

Hi,

First I want to say thanks for the PR! However, before we could look at accepting it I'd need to ask you to look at the specs because they have all broken. :) It's as simple as adding in the -y to the expected commands (if you look at the travis output in this PR you can see what's failing currently).

@oleiade
Copy link
Author

oleiade commented Jul 17, 2013

Sorry for that, I'm not used to rspec and didn't thought about. I fixed it by adding the options passing to apt::ppa tests. Travis says it's okay now :)

@apenney
Copy link

apenney commented Jul 17, 2013

Awesome, thanks for this contribution!

apenney pushed a commit that referenced this pull request Jul 17, 2013
Fix: parametrize apt::ppa class for beign able to pass options to apt-add-repository command
@apenney apenney merged commit e4fe87c into puppetlabs:master Jul 17, 2013
@oleiade oleiade deleted the handle_ppa_options branch July 17, 2013 12:25
@hunner hunner mentioned this pull request Aug 5, 2013
@LukasAud LukasAud added the bugfix label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants