Fix: parametrize apt::ppa class for beign able to pass options to apt-add-repository command #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Using the puppetlabs-apt module on our platform we've noticed that even if we manualy added repositories keys before adding a launchpad repo using
apt::ppa
class, the operation would fail becauseapt-add-repository
would ask for user input.We've fixed the
apt::ppa
class to support aoptions
parameter allowing to pass options to the underlyingapt-add-repository
execution. As a default 'options' is set to '-y' to avoid user prompt. We found it might be usefull to anyone so here's our pull request.Thanks