Add ability to specify hash of apt sources in hiera #192
Conversation
This patch uses create_resources() to call apt::source which lets you specify your sources in hiera.
|
@apenney any ideas on why this is failing travis so hard? This patch works great for me with puppet 3.3.2 and ruby 1.8.7. |
|
I'm a bit on the fence about this one. On one hand I understand why you'd want to be able to do this, on the other hand you can already easily do this without us needing to support it in the module. I'd certainly want to add an example like this to the README but I'm not convinced the module should handle this for you. |
|
Every time you have a define, there should be a create_resources() that goes with it. This gives you the ability to specify a hash and use the define within Hiera. Without this functionality, defines require that I write puppet code, which would end up being a module that just had create_resources() to call the define. In other words, this is a design pattern that has greatly simplified being able to define things in Hiera as opposed to writing more code or meta modules. |
| @@ -0,0 +1 @@ | |||
| /home/dan/git/puppetlabs-apt | |||
There was a problem hiding this comment.
spec/fixtures/modules should not be in the commit and should be added to .gitignore
Hadn't considered that, good point. The reasons the tests seem to have failed so explosively is because stdlib couldn't be found. I'm guessing it was a bug in the @dantremblay: I'll push to get the feature in but your commit needs to:
|
|
@daenney I went ahead and did this work and rebased Dan's commit in PR #249. Didn't think Dan would mine as we worked on this PR together. @dantremblay can you please close this PR? |
This patch uses create_resources() to call apt::source which lets you specify your sources in hiera.