Fix fail message

[electrical]

the fail message was including a fact that was not used in the whole case statement and caused some confusion.

[daenney]

I'm gonna be the annoying community person that's too involved in this but knowing what kind of spec hero you are, could you add a test for that failure message just to prevent someone from bringing the issue back?

[daenney]

This is good, should merge. @hunner @apenney

[hunner]

The reason I added $::osfamily even though it's not in the case statement is that if the module is applied to something without $::lsbdistid like Windows (yeah, I know...) then the error message would be less helpful without it.

[electrical]

@hunner ahh okay. kinda makes sense. will close PR then,

[daenney]

I don't agree with the rationale. @electrical's error message was much better than with the osfamily because the osfamily can obscure the actual error.

Since this module won't ever make any sense on any platform but Debian it should have code in it that bails it out:

if $::osfamily != Debian {
  fail('This module only works on Debian or derivatives like Ubuntu')
}

Now the user knows exactly why it's blowing up and the other error messages in params.pp can reflect the actual cause if it is running on a supported distro.

[hunner]

++ to that! :) Want to update the PR @electrical ?

[hunner]

Also, spec/acceptance/unsupported_spec.rb will have to be updated for that error message.

[electrical]

@hunner will do. Will have a PR after the weekend.

[daenney]

@electrical Pwetty please? 😄

[electrical]

Will try to spend some time on it tomorrow :-)

[electrical]

Working on it today. sorry for the delay

[daenney]

@hunner Take it away!