Fixed regex to follow APT requirements #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation would overwrite the file name and potentially include characters that would cause apt to ignore the pref file
|
Still need tests on this. |
|
Hi, I'm not quite sure what kind of test you would require? Do you need to test on the generated file name, on whether non-accepted characters get replaced? I assumed the current tests already covered it, hence my relying on the travis build. |
|
Oh you're right, we already had some specs covering this and nothing broke. I think I'm good, @apenney. |
apenney
pushed a commit
that referenced
this pull request
May 22, 2014
Fixed regex to follow APT requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation would overwrite the file name and potentially include characters that would cause apt to ignore the pref file.
What would happen is that $path would use $name by default.
Then the regex would generate a valid $file_name, then ignore completely by using previously set $path, allowing forbidden characters in the file name.