Allow for custom comment in sources.list file #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thank you, I'll have a look at it later. Tip for next time, opening a PR with title '...' is unlikely to cause it to get much attention from our part when we're skimming the list op PR's. |
underscorgan
pushed a commit
that referenced
this pull request
Jun 19, 2014
…s-list Allow for custom comment in sources.list file
|
I just remembered - should I submit a new PR for a modified example in the README.md as well? |
|
If you want to that'd be great. Mention #311 in the commit so it gets linked here too. |
daenney
pushed a commit
that referenced
this pull request
Jun 23, 2014
…omment-parameter Update apt::source example in README.md for #311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment source.pp simply adds a comment with the name in the $name.list file. This patch allows a custom comment after the 'file generated by puppet' line. If a comment value is not provided, the default comment remains the name.