(#13125) Apt keys should be case insensitive

[blkperl]

Previously lowercase keys would be installed every
puppet run because apt-key list returns an uppercase
key. This commit makes the comparison case insensitive.

[haus]

This looks like it shouldn't do the right thing. ${$upkey} should be ${upkey}, no?

[blkperl]

Fixed, forced pushed

[haus]

So would changing all of the greps to grep -i not work in this case?

[blkperl]

marut thought it would better to use stdlib's upcase method rather than adding more flags to grep.

Maybe @marut can explain his thought process. I've already forgotten the reason :)

[reidmv]

I don't have any strong feelings on the grep -i option. I usually operate with the starting perspective that I trust puppet to be consistent more than I trust exec'd commands to be consistent, hence the suggestion to explore upcase'ing instead of grep -iing. It's all largely moot now but in hindsight the upcase solution is sufficiently more complicated than the grep -i option would have been that K.I.S.S. sez grep -i would have been better; certainly from a maintainability standpoint. @blkperl, if you want to push a revert,grep -i pull request I'd support it. Not a priority though, the current solution is functional, just complicated. Sorry for pushing you in that direction.