apt-check (oddly) outputs its result to stderr #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay with this but... I'm only willing to pull in this patch if the bug is reported and discussed with upstream. Outputting results to stderr is a bug, only error information and usage information as a result of bad arguments is supposed to end up on stderr. |
|
While we wait for this bug to be reported and discussed you might convey your position on #382 which proposes the same change; I'd hate to see this regression fix slip in unnoticed. |
|
Submitted an updated version of this as #403 that has working tests and some additional error checking. |
|
Closing in favour of #403. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes apt-check, broken by 9755612, while we wait on more robust solution for when
apt-checkcannot be found #382.