Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate apt::pin for apt::backports to allow pin by release instead of ... #398

Merged
merged 1 commit into from
Jan 28, 2015

Conversation

riconnon
Copy link

Currently apt::backports creates a ineffective pin when using debian 7 because backports and the main repo share an origin. Pinning by release can, for this reason, be more reliable for backports.

@riconnon riconnon force-pushed the backports-pin branch 5 times, most recently from 72040e8 to 3933b95 Compare December 14, 2014 22:45
@underscorgan
Copy link

@irconan thanks for the contribution! In general this looks good to me, though I'd like @daenney to confirm this looks reasonable. Also, we'd like to have this squashed down to a single commit.

@riconnon
Copy link
Author

I've squashed these commits for you. Let me know if you see anything else you'd like changing.

@daenney
Copy link

daenney commented Jan 28, 2015

This does seem like a better idea but it does mean we're changing behaviour for users under the hood. Thankfully we're still managing the same file in the end so it'll just update the current pin instead of creating two conflicting ones.

One more reason to remove apt::backports in its entirety, there's no way to do this right by everyone.

Overall I'm 👍 on this.

underscorgan pushed a commit that referenced this pull request Jan 28, 2015
Separate apt::pin for apt::backports to allow pin by release instead of ...
@underscorgan underscorgan merged commit 2415f23 into puppetlabs:master Jan 28, 2015
@underscorgan
Copy link

Thanks for the contribution @irconan , and thanks for the feedback @daenney !

@raoulbhatia
Copy link

Isn't this basically what i did in #313 ? ;)

Well,
glad that this functionality is merged now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants