Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we configure the proxy before doing apt-get update. #41

Merged
merged 1 commit into from
May 3, 2012
Merged

Make sure we configure the proxy before doing apt-get update. #41

merged 1 commit into from
May 3, 2012

Conversation

tbroyer
Copy link

@tbroyer tbroyer commented Mar 31, 2012

In the case your machine can't access the internet except through a proxy, you want it to be set before you do the apt-get update!

I used a notify dependency just in case you forgot to set the proxy in the first place (or mistyped it) and thus had the apt-get update failing. Without the notify, the apt-get update wouldn't get executed after you fix the proxy issue, as the sources.list and sources.list.d would have been set in the first (failing) run (I mean, unless you use always_apt_update, but that's another story).

I didn't set a dependency on the python-software-properties package because:

  1. I believe it should be moved to apt::ppa (see Move Package['python-software-properties'] to apt:ppa #40)
  2. you'll probably have something like this defined: Class['apt'] -> Package <| |> which would then guarantee the apt-get update will be executed before you install any package

nanliu added a commit that referenced this pull request May 3, 2012
Make sure we configure the proxy before doing apt-get update.
@nanliu nanliu merged commit 51a7596 into puppetlabs:master May 3, 2012
@tbroyer tbroyer deleted the install-proxy-first branch March 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants