Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use the strict variables workaround if using strict variables #524

Merged
merged 1 commit into from
May 11, 2015

Conversation

underscorgan
Copy link

This prevents issues where there's a mismatch in agent/master versions

@daenney
Copy link

daenney commented May 11, 2015

Haha. Oh wow. 😢 😭.

@underscorgan
Copy link
Author

This feels moderately less terrible than checking the version on the agent and then trying to run the function on the master...

@underscorgan underscorgan changed the title Rather than checking puppetversion, check if defined actually works (DO NOT MERGE) Rather than checking puppetversion, check if defined actually works May 11, 2015
This should avoid issues with defined on earlier versions of puppet
@underscorgan underscorgan force-pushed the better_defined_check branch from 0ac4b82 to 3838c66 Compare May 11, 2015 17:56
@underscorgan underscorgan changed the title (DO NOT MERGE) Rather than checking puppetversion, check if defined actually works Only use the strict variables workaround if using strict variables May 11, 2015
@underscorgan
Copy link
Author

I think this is the least hackery way of doing this, thanks @hunner !

@daenney
Copy link

daenney commented May 11, 2015

Oh hah, that is way better!

daenney added a commit that referenced this pull request May 11, 2015
Only use the strict variables workaround if using strict variables
@daenney daenney merged commit 535a5b6 into puppetlabs:master May 11, 2015
@underscorgan underscorgan deleted the better_defined_check branch May 11, 2015 18:34
@LukasAud LukasAud added the bugfix label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants