Backwards compatibility with older versions of puppet

[ianmacl]

What you'll find on older versions of Puppet is that if a hash has a key with a value that is false, the value will not get defined. Consequently, when you try to match against true or false, an error will be triggered because the value is not defined. The suggested fix is to match against true and then use default to catch the false case.

I would be happy to write tests/specs for this, but am unsure how to write tests that target specific versions of Puppet. If you can provide pointers that would be great!

[daenney]

Thanks for this. We've had a couple of those 'features' because of how defined behaves before and after Puppet 3.5. That change should in hindsight have been considered a breaking change as far as I'm concerned 😒.

Writing spec tests specifically targeting a Puppet version is needlessly complicated. We tend to run the integration tests by hand for 3.4 and 3.6 and then see if something breaks. Since the unit tests are green I'm pretty positive this doesn't break anything on modern versions of Puppet.

@mhaskel Could you verify this somehow, please? Sorry to stick you with this but I can barely get Beaker to work locally.

[underscorgan]

@ianmacl sorry for the delay, but this seems to behave as expected, so thank you!

[ianmacl]

Thanks so much for your help getting this fixed.

On Mon, Jun 8, 2015, 6:09 PM Morgan Haskel notifications@github.com wrote:

@ianmacl https://github.com/ianmacl sorry for the delay, but this seems
to behave as expected, so thank you!

—
Reply to this email directly or view it on GitHub
#525 (comment)
.