Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor issues #547

Merged
merged 2 commits into from
Jul 21, 2015
Merged

Fix anchor issues #547

merged 2 commits into from
Jul 21, 2015

Conversation

underscorgan
Copy link

No description provided.

@@ -6,6 +6,8 @@
$package_name = $::apt::ppa_package,
$package_manage = false,
) {
Apt::Ppa[$title] -> Class['apt::update']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work/make sense, to have in the same resource declaration? Also, since the necessary resources already notify apt::update, isn't that enough?

@underscorgan underscorgan changed the title Fix anchor issues [DO NOT MERGE] Fix anchor issues Jul 20, 2015
@underscorgan underscorgan force-pushed the MODULES-2190 branch 3 times, most recently from 32d0fd7 to 436d645 Compare July 21, 2015 00:18
@underscorgan
Copy link
Author

This doesn't actually fix the issue, it just means that user's should be able to add dependencies on Class['apt::update'] or add collectors or somethign without getting dependency cycles. Do you have any brilliant ideas @daenney ?

I was trying to repro with

    include apt
    apt::ppa { 'ppa:webupd8team/java': }

    package { 'oracle-java8-installer':
        responsefile => '/tmp/java.preseed',
        require      => Apt::Ppa['ppa:webupd8team/java']
    }

@daenney
Copy link

daenney commented Jul 21, 2015

I think this is doable. It doesn't introduce any weird half-broken anchors to support a use case so I'm okay with this.

The one thing I am confused about, what's the difference between include "apt::update" vs include apt::update? Imho that should be include ::apt::update to force a fully qualified lookup 😄.

@underscorgan underscorgan changed the title [DO NOT MERGE] Fix anchor issues Fix anchor issues Jul 21, 2015
@underscorgan
Copy link
Author

fixed :)

tphoney added a commit that referenced this pull request Jul 21, 2015
@tphoney tphoney merged commit fa86d8e into puppetlabs:master Jul 21, 2015
@underscorgan underscorgan deleted the MODULES-2190 branch July 21, 2015 18:01
@daenney
Copy link

daenney commented Jul 21, 2015

Lets see what happens next 😉

@LukasAud LukasAud added the bugfix label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants