-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anchor issues #547
Fix anchor issues #547
Conversation
@@ -6,6 +6,8 @@ | |||
$package_name = $::apt::ppa_package, | |||
$package_manage = false, | |||
) { | |||
Apt::Ppa[$title] -> Class['apt::update'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work/make sense, to have in the same resource declaration? Also, since the necessary resources already notify apt::update
, isn't that enough?
32d0fd7
to
436d645
Compare
This doesn't actually fix the issue, it just means that user's should be able to add dependencies on Class['apt::update'] or add collectors or somethign without getting dependency cycles. Do you have any brilliant ideas @daenney ? I was trying to repro with
|
I think this is doable. It doesn't introduce any weird half-broken anchors to support a use case so I'm okay with this. The one thing I am confused about, what's the difference between |
436d645
to
cd37fc3
Compare
fixed :) |
Lets see what happens next 😉 |
No description provided.