Make apt_updates facts use /usr/bin/apt-get. #581
Conversation
|
I'm OK with this, but it's broken all the tests around it. |
|
Yes, I noticed. Never occured to me to change those too. Will update the request. |
|
Tests have been changed. |
|
Perfect, thanks. Could you squash and rebase this so we can merge? |
/usr/lib/update-notifier/apt-check is not available on all systems, but /usr/bin/apt-get is.
|
Sqashed and rebased. |
|
Thanks! |
| / Debian-Security:/, | ||
| / Ubuntu[^\s]+-security /, | ||
| / gNewSense[^\s]+-security / | ||
| ] |
There was a problem hiding this comment.
I'm concerned about security_matches not working correctly on all target distributions such as Linux Mint etc.
There was a problem hiding this comment.
I agree, security_matches will not match every current and future security repository. But the current list of matches is a representation of what was found in /usr/lib/update-notifier/apt-check on Ubuntu. Mint has the same file with the same checks as far as I can see.
|
@daenney PCCI is currently on the fritz. Once that's back up I will take a look at the results of the acceptance tests run. |
|
@bmjen Doesn't PL have its own infra for this? 😛 |
|
Nudge @bmjen. |
|
@daenney sorry. Forgot about this. Acceptance tests pass on trusty for this PR. Still need to investigate the facter question you posed. |
|
@bmjen Do you think we can merge this now? Is Facter 2 a major concern for us at present? Perhaps it is if Puppet 3.8 uses it? Thanks |
|
@jonnytpuppet @daenney I think we should have a ticket for one of us to run this PR locally with facter 2.x and 3.x to make sure we don't break compatibility before merging. |
|
MODULES-3198 it is. |
|
Thank you @hunner for checking the specs and thanks @robinelfrink for the contribution! |
apt_updates.rb currently uses /usr/lib/update-notifier/apt-check to check for available updates.
This is part of update-notifier-common, which is not available on all systems.