Look for correct sources.list.d file for apt::ppa #582
Conversation
|
This has broken the tests. |
|
@imphil thanks for the work, it does need rebased. |
|
sorry, i know it is annoying. |
|
@tphoney , don't worry. I just didn't find time to get into the details of how to run the tests, as they still fail and need to be adjusted. Maybe this week. |
|
I appreciate the effort 👍 |
"man apt-add-repository" notes: "REPOSITORY can be either a line that can be added directly to sources.list(5), in the form ppa:<user>/<ppa-name> for adding Personal Package Archives". Fix the tests to always use the format ppa:<user>/<ppa-name> when adding PPAs.
In Ubuntu 15.10 the path of the apt sources file, which is generated by apt-add-repository, changed to include the distid. This breaks apt::ppa idempotency, since it does not recognize the repository is already added. Reported on puppet-users as well: https://groups.google.com/forum/#!topic/puppet-users/YzeMyZYUo98
|
Here we go. Please let me know if that's OK or if other changes are needed. |
|
The code looks good to me @imphil. I am not an expert in apt, so i will get this raised in the community meeting tomorrow. Where it will be reviewed. Thanks again for the work !! |
|
It seems alright to me but we'd need to check on the Beaker tests before merging this. |
|
@tphoney @daenney Acceptance tests appear to run clean on PCCI. https://ci.voxpupuli.org/buildlogs/puppetlabs+puppetlabs-apt+582+1454517856+PASS |
Look for correct sources.list.d file for apt::ppa
In Ubuntu 15.10 the path of the apt sources file, which is generated by
apt-add-repository, changed to include the distid. This breaks apt::ppa
idempotency, since it does not recognize the repository is already
added.
Reported on puppet-users as well:
https://groups.google.com/forum/#!topic/puppet-users/YzeMyZYUo98